-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy JSON Schema #576
Policy JSON Schema #576
Conversation
and a stub for rule definition
* cache the read file in a global dict * provide filtering overloads for common use cases * remove duplicated code and unnecessary params
stub rule states
maps vehicle_state to vehicle_event[]
used by policy and stops
to maintain definition reusability
* ensure valid combinations * require rule_units for all but rule_type: user * require rate_* fields for rule_type: rate
filter by args first! adding comments
Beyond all the detailed work on the Policy schema and examples, it also looks like you have some critical updates to the Policy readme. It seems like it would be good to get this into 1.0.0, especially since the schema applies to 1.0.0 and it may change a lot in 1.1.0 based on what's being worked on. Do you think this should be in the 1.0.0 release, possibly approved this week? Tagging @jfh01 @Karcass @hunterowens in case they want to weigh in. |
That was my hope. The (current) examples for Policy aren't correct under 1.0, so it would great to get this update pushed in time. |
I am planning on merging this to the 1.0.0 release tomorrow. The new items are defining a schema for Policy, something that's been missing and known to be needed since its creation. The changed items are critical updates to links and the spec that were either missing or incorrect. If we need further changes or updates to this we can open a new PR and address them in the next release or with a hotfix. |
JSON Schema describing MDS 1.0 Policy.
The examples have been pulled out into distinct files in a subdirectory and updated to pass schema validation.
Closes #389.