Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy JSON Schema #576

Merged
merged 21 commits into from
Sep 15, 2020
Merged

Policy JSON Schema #576

merged 21 commits into from
Sep 15, 2020

Conversation

thekaveman
Copy link
Collaborator

JSON Schema describing MDS 1.0 Policy.

The examples have been pulled out into distinct files in a subdirectory and updated to pass schema validation.

Closes #389.

@thekaveman thekaveman added Schema Implications for JSON Schema or OpenAPI Policy Specific to the Policy API labels Sep 14, 2020
@thekaveman thekaveman requested a review from a team September 14, 2020 16:20
@thekaveman thekaveman requested a review from a team as a code owner September 14, 2020 16:20
@thekaveman thekaveman requested a review from a team September 14, 2020 16:20
@schnuerle
Copy link
Member

Beyond all the detailed work on the Policy schema and examples, it also looks like you have some critical updates to the Policy readme. It seems like it would be good to get this into 1.0.0, especially since the schema applies to 1.0.0 and it may change a lot in 1.1.0 based on what's being worked on.

Do you think this should be in the 1.0.0 release, possibly approved this week? Tagging @jfh01 @Karcass @hunterowens in case they want to weigh in.

@schnuerle schnuerle added this to the 1.0.0 milestone Sep 14, 2020
@thekaveman
Copy link
Collaborator Author

Do you think this should be in the 1.0.0 release, possibly approved this week?

That was my hope. The (current) examples for Policy aren't correct under 1.0, so it would great to get this update pushed in time.

@schnuerle
Copy link
Member

I am planning on merging this to the 1.0.0 release tomorrow.

The new items are defining a schema for Policy, something that's been missing and known to be needed since its creation. The changed items are critical updates to links and the spec that were either missing or incorrect.

If we need further changes or updates to this we can open a new PR and address them in the next release or with a hotfix.

@schnuerle schnuerle linked an issue Sep 15, 2020 that may be closed by this pull request
@schnuerle schnuerle merged commit 06013b9 into openmobilityfoundation:release-1.0.0 Sep 15, 2020
@thekaveman thekaveman deleted the policy-schema branch September 19, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Policy Specific to the Policy API Schema Implications for JSON Schema or OpenAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schemas for the Policy Endpoints
2 participants